Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130858 / 24.10-RC.1 / remove file exclusion from ixdiagnose on enterprise systems (by themylogin) #219

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

bugclerk
Copy link

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@7726a20). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ixdiagnose/plugins/system_state.py 16.66% 15 Missing ⚠️
ixdiagnose/utils/command.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel     #219   +/-   ##
=====================================================
  Coverage                      ?   91.64%           
=====================================================
  Files                         ?      103           
  Lines                         ?     2323           
  Branches                      ?        0           
=====================================================
  Hits                          ?     2129           
  Misses                        ?      194           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yocalebo yocalebo merged commit df9b418 into stable/electriceel Aug 30, 2024
6 checks passed
@yocalebo yocalebo deleted the NAS-130858-24.10-RC.1 branch August 30, 2024 12:03
@bugclerk
Copy link
Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants